108 lines
9.0 KiB
JavaScript
108 lines
9.0 KiB
JavaScript
import test from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import { randomUUID } from 'node:crypto';
|
|
import { fixture, launchWorkbench } from './helpers.mjs';
|
|
import { beginPlanTask, completeRead } from './fixtures/task-plan-fixture.mjs';
|
|
import { RequirementReview } from '../src/core/tasks/requirement-review.mjs';
|
|
import { draftSegments, requirementSources, sourceSetHash } from '../src/core/tasks/requirement-drafts.mjs';
|
|
|
|
const create = async f => {
|
|
const manager = new RequirementReview(f.store), view = await manager.inspect(f.session);
|
|
const draft = await manager.createDraft(f.session, { expected_revision: view.revision, source_set_sha256: view.source_set_sha256 });
|
|
return { manager, view, draft };
|
|
};
|
|
const scope = row => ({ key: row.key, title: row.title, criterion: row.criterion, role: row.role, kind: 'analysis', method: 'scope',
|
|
source: { kind: row.source.kind, id: row.source.id, start: row.source.start, end: row.source.end } });
|
|
const input = (view, draft, rows = draft.proposal.items.map(scope)) => ({ expected_revision: view.revision, source_set_sha256: view.source_set_sha256,
|
|
reviewed_source_ids: view.sources.map(row => row.id), draft_id: draft.id, requirements: rows });
|
|
|
|
test('local draft preserves exact original ranges and duplicate source instances without inferring outputs or accepting facts', async t => {
|
|
const f = fixture(t); beginPlanTask(f, '参考 README.md;仅说明如何修改,不执行修改。无需测试。');
|
|
const task = f.store.core.task.get(f.session.taskId);
|
|
task.instructions.push({ id: randomUUID(), source: 'user', content: task.goal, createdAt: new Date().toISOString() });
|
|
const history = structuredClone(f.session.providerMessages), { manager, view, draft } = await create(f);
|
|
assert.equal((await manager.inspect(f.session)).configured, false); assert.equal(task.requirementProofs, undefined);
|
|
assert.ok(draft.proposal.items.length >= 6); assert.equal(draft.proposal.truncated, false);
|
|
for (const item of draft.proposal.items) {
|
|
const source = view.sources.find(row => row.id === item.source.id);
|
|
assert.equal(item.source.quote, source.text.slice(item.source.start, item.source.end));
|
|
assert.equal(item.role, 'unknown'); assert.equal(item.paths, undefined); assert.equal(item.evidence, undefined);
|
|
}
|
|
assert.notEqual(draft.proposal.items[0].source.sourceSha256, draft.proposal.items.at(-3).source.sourceSha256);
|
|
assert.equal((await manager.createDraft(f.session, { expected_revision: 0, source_set_sha256: view.source_set_sha256 })).id, draft.id);
|
|
assert.equal(task.requirementDrafts.length, 1); assert.deepEqual(f.session.providerMessages, history);
|
|
assert.equal(f.session.changes.length, 0); assert.equal(f.store.core.check_job.size, 0);
|
|
});
|
|
|
|
test('review keeps unknown blocking, references distinct from output and boundaries distinct from compliance evidence', async t => {
|
|
const f = fixture(t); beginPlanTask(f, '参考 README.md;禁止修改原文件;交付范围待澄清。');
|
|
const { manager, view, draft } = await create(f);
|
|
const rows = draft.proposal.items.map((row, i) => scope({ ...row, role: ['reference', 'prohibition', 'unknown'][i] }));
|
|
await manager.save(f.session, input(view, draft, rows));
|
|
const current = await manager.inspect(f.session);
|
|
assert.deepEqual(current.items.map(row => row.status), ['reference_recorded', 'boundary_recorded', 'scope_unknown']);
|
|
assert.equal(current.all_resolved, false); assert.equal(f.store.core.task.get(f.session.taskId).requirementProofs, undefined);
|
|
await assert.rejects(manager.verify(f.session, { expected_revision: 1, key: rows[0].key, evidence_id: randomUUID() }), /需要复核/);
|
|
await assert.rejects(manager.assertReady(f.session), /待复核/);
|
|
});
|
|
|
|
test('draft adoption must account for every original range and does not fill paths from a reference', async t => {
|
|
const f = fixture(t); beginPlanTask(f, '参考README.md;修改notes.md。'); const { manager, view, draft } = await create(f);
|
|
await assert.rejects(manager.save(f.session, input(view, draft, [scope(draft.proposal.items[0])])), /未归类原文/);
|
|
const rows = draft.proposal.items.map(scope);
|
|
rows[1] = { ...rows[1], role: 'requirement', kind: 'results', method: 'evidence', paths: [] };
|
|
await assert.rejects(manager.save(f.session, input(view, draft, rows)), /文件路径/);
|
|
rows[1].paths = ['notes.md']; await manager.save(f.session, input(view, draft, rows));
|
|
const current = await manager.inspect(f.session); assert.deepEqual(current.items[1].paths, ['notes.md']);
|
|
assert.equal(current.items[1].status, 'pending'); assert.equal(current.items[0].status, 'scope_unknown');
|
|
});
|
|
|
|
test('source and requirement changes, other Tasks and tampered draft bytes are rejected without losing originals', async t => {
|
|
const f = fixture(t); beginPlanTask(f, '研究README.md。'); const { manager, view, draft } = await create(f);
|
|
const task = f.store.core.task.get(f.session.taskId);
|
|
task.instructions.push({ id: randomUUID(), source: 'user', content: '新增要求', createdAt: new Date().toISOString() });
|
|
await assert.rejects(manager.save(f.session, input(view, draft)), /来源已变化/);
|
|
const latest = await create(f), originalTitle = latest.draft.proposal.items[0].title;
|
|
latest.draft.proposal.items[0].title = '伪造完成';
|
|
await assert.rejects(manager.save(f.session, input(latest.view, latest.draft)), /原工件不一致/);
|
|
latest.draft.proposal.items[0].title = originalTitle;
|
|
const other = fixture(t); beginPlanTask(other, '另一个任务'); const independent = await create(other);
|
|
await assert.rejects(independent.manager.save(other.session, { ...input(independent.view, independent.draft), draft_id: draft.id }), /不属于/);
|
|
assert.equal(task.requirementDrafts.length, 2); assert.equal(task.requirementRevisions, undefined);
|
|
});
|
|
|
|
test('partial explicit source review leaves the other source unreviewed while old file evidence remains valid', async t => {
|
|
const f = fixture(t); beginPlanTask(f, '研究README.md'); const manager = new RequirementReview(f.store), read = completeRead(f);
|
|
const first = { key: 'read', title: '原文依据', criterion: '当前读取', kind: 'analysis', tools: ['read_file'], method: 'evidence', source: { kind: 'goal', id: f.session.taskId, start: 0, end: 10 } };
|
|
await manager.save(f.session, { expected_revision: 0, requirements: [first] }); await manager.verify(f.session, { expected_revision: 1, key: 'read', evidence_id: read.id });
|
|
f.store.core.task.get(f.session.taskId).instructions.push({ id: randomUUID(), source: 'user', content: '新目标待确认' });
|
|
const view = await manager.inspect(f.session);
|
|
await manager.save(f.session, { expected_revision: 1, source_set_sha256: view.source_set_sha256, reviewed_source_ids: [f.session.taskId], requirements: [first] });
|
|
const current = await manager.inspect(f.session); assert.equal(current.unreviewed_sources.length, 1); assert.equal(current.items[0].status, 'evidence_verified');
|
|
assert.equal(current.all_resolved, false);
|
|
});
|
|
|
|
test('bounded draft does not claim full source coverage and cannot acknowledge an omitted remainder', async t => {
|
|
const f = fixture(t); beginPlanTask(f, Array.from({ length: 30 }, (_, i) => '第' + i + '项原文。').join(''));
|
|
const { manager, view, draft } = await create(f); assert.equal(draft.proposal.items.length, 24); assert.equal(draft.proposal.truncated, true);
|
|
assert.deepEqual(draft.proposal.covered_source_ids, []);
|
|
await assert.rejects(manager.save(f.session, input(view, draft)), /未覆盖完整原文/);
|
|
const sources = requirementSources(f.store.core.task.get(f.session.taskId)); assert.equal(sourceSetHash(sources), view.source_set_sha256);
|
|
assert.equal(draftSegments(sources, { characters: 5 }).truncated, true);
|
|
});
|
|
|
|
test('draft HTTP preserves its original artifact across restart and rejects stale scope and source versions', async t => {
|
|
const f = fixture(t); beginPlanTask(f, '参考README.md,不修改。'); f.store.close();
|
|
let host = await launchWorkbench(t, f.data); const base = '/sessions/' + f.session.id;
|
|
const view = await host.api(base + '/requirements?taskId=' + f.session.taskId);
|
|
const request = { taskId: f.session.taskId, runId: f.session.runId, expected_revision: 0, source_set_sha256: view.source_set_sha256 };
|
|
await assert.rejects(host.api(base + '/requirement-drafts', { ...request, runId: randomUUID() }), /原任务或运行/);
|
|
const generated = await host.api(base + '/requirement-drafts', request); assert.equal(generated.requirements.configured, false);
|
|
const original = generated.draft; await host.close(); host = await launchWorkbench(t, f.data);
|
|
const restored = await host.api(base + '/requirement-drafts', request); assert.deepEqual(restored.draft, original);
|
|
const saved = await host.api(base + '/requirements', { taskId: f.session.taskId, runId: f.session.runId, ...input(view, original) });
|
|
assert.equal(saved.requirements.items[0].status, 'scope_unknown');
|
|
await assert.rejects(host.api(base + '/requirement-drafts', request), /修订/);
|
|
await assert.rejects(host.api(base + '/requirements', { taskId: f.session.taskId, runId: f.session.runId, ...input(view, original) }), /修订/);
|
|
});
|