fix(ci): keep binary source explicit and Python logs in UTF-8
This commit is contained in:
@@ -6,7 +6,7 @@ import path from 'node:path';
|
||||
import { execFileSync } from 'node:child_process';
|
||||
import { fileURLToPath } from 'node:url';
|
||||
import YAML from 'yaml';
|
||||
import { createCiRun, ciEnvironment, loggedCommand, tapTotals, requireCompleteTests, unpackVerifiedSource, fileDigest } from '../scripts/ci-utils.mjs';
|
||||
import { createCiRun, ciEnvironment, loggedCommand, tapTotals, requireCompleteTests, unpackVerifiedSource, fileDigest, binaryMirror } from '../scripts/ci-utils.mjs';
|
||||
import { packageSource } from '../scripts/package-source.mjs';
|
||||
import { verifyCiWorkflow } from '../scripts/verify-ci-workflow.mjs';
|
||||
|
||||
@@ -23,6 +23,11 @@ test('fresh output runs are separate and excluded credential getters are never r
|
||||
assert.equal(fs.readFileSync(env.npm_config_userconfig,'utf8'),''); assert.notEqual(env.npm_config_userconfig,env.npm_config_globalconfig);
|
||||
});
|
||||
|
||||
test('a download mirror is an explicit public HTTPS directory and cannot carry credentials in URL or query',()=>{
|
||||
assert.equal(binaryMirror(undefined),null);assert.equal(binaryMirror('https://npmmirror.com/mirrors/electron/'),'https://npmmirror.com/mirrors/electron/');
|
||||
for(const value of ['http://example.invalid/electron/','https://owned:credential@example.invalid/','https://example.invalid/?token=owned','https://example.invalid/electron/#owned','https://example.invalid/file.zip'])assert.throws(()=>binaryMirror(value));
|
||||
});
|
||||
|
||||
test('actual nonzero command, original stdout/stderr and spawn failure survive without replay or log overwrite',async t=>{
|
||||
const run=createCiRun(owned(t),'contract'),env=ciEnvironment(run);
|
||||
const result=await loggedCommand({id:'original-failure',executable:process.execPath,args:['-e',"process.stdout.write('original\\n');process.stderr.write('failure\\n');process.exitCode=7"],cwd:run.source,env,evidence:run.evidence,check:false});
|
||||
|
||||
Reference in New Issue
Block a user